Skip to content

Plugwise docs updated to match pull-request #28237 #11004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2019
Merged

Plugwise docs updated to match pull-request #28237 #11004

merged 2 commits into from
Nov 7, 2019

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 26, 2019 •
edited
Loading

Description:

Pull request in home-assistant (if applicable): home-assistant/core#28237

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in another repo current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 26, 2019
klaasnicolaas
klaasnicolaas previously requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be merged in the next branch, please rebase this PR

@klaasnicolaas klaasnicolaas added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 31, 2019
@bouwew bouwew changed the base branch from current to next November 3, 2019 09:57
@probot-home-assistant probot-home-assistant bot added next This PR goes into the next branch and removed current This PR goes into the current branch labels Nov 3, 2019
@bouwew bouwew mentioned this pull request Nov 3, 2019
Merged
6 tasks
@bouwew bouwew requested a review from klaasnicolaas November 3, 2019 15:32
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 4, 2019
@frenck frenck dismissed klaasnicolaas’s stale review November 4, 2019 09:33

Comments addressed

@frenck frenck added awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Nov 4, 2019
@frenck frenck merged commit 74335a5 into home-assistant:next Nov 7, 2019
@probot-home-assistant probot-home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Nov 7, 2019
@bouwew bouwew deleted the patch-1 branch November 8, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

@klaasnicolaas klaasnicolaas Awaiting requested review from klaasnicolaas

Assignees
No one assigned
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouwew @frenck @klaasnicolaas