Skip to content

Conversation

springstan
Copy link
Member

Description:

  • added default value for name
  • fixed hidden configuration variables

Result:
grafik

Pull request in home-assistant (if applicable): home-assistant/core#28279

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in another repo current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 28, 2019
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Oct 30, 2019
@fabaff
Copy link
Member

fabaff commented Oct 30, 2019

This needs to go to the next branch.

@springstan
Copy link
Member Author

Should I open a new PR against the next branch and close this one?

@klaasnicolaas klaasnicolaas added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 30, 2019
@klaasnicolaas
Copy link
Member

You can rebase this PR to the next branch or create a new PR.

@springstan
Copy link
Member Author

Okay thanks! I created a new one #11051

@probot-home-assistant probot-home-assistant bot added Invalid and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch parent-merged The parent PR has been merged already Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in another repo Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants