Skip to content

clarify options' use #11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2019
Merged

clarify options' use #11189

merged 3 commits into from
Nov 28, 2019

Conversation

akasma74
Copy link
Contributor

The current description looks outdated to me because:

  1. In Lovelace the time/date is not displayed when we open default_view
  2. If only - 'time' specified, no sensor.date or anything else exists (and it's not clear as the configuration variable name is display_options (maybe now it's better to make it deprecated and change to options or something)?

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

The current description looks outdated to me because:
1. In Lovelace the time/date is not displayed when we open default_view
2. If only - 'time' specified, no `sensor.date` or anything else exists (and it's not clear as the configuration variable name is `display_options` (maybe now it's better to make it deprecated and change to `options` or something)?
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Nov 15, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the PR @akasma74!

Left a couple of comments, could you take a look? Thanks! 👍

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Nov 16, 2019
akasma74 and others added 2 commits November 16, 2019 20:10
typo

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @akasma74! 👍

@frenck frenck merged commit 0be2778 into home-assistant:current Nov 28, 2019
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants