Update homekit.markdown: URL encode space char #11542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure this addition to the URL works for everyone - it looks like unprivileged users can't label new issues, but this *does* fix the formatting of the link.
ochlocracy
pushed a commit
to ochlocracy/home-assistant.io
that referenced
this pull request
Jan 22, 2020
I'm not sure this addition to the URL works for everyone - it looks like unprivileged users can't label new issues, but this *does* fix the formatting of the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix URL formatting for new issues.
The current un-encoded space character shows markdown formatting on https://www.home-assistant.io/integrations/homekit/#specific-entity-doesnt-work
Using
%20instead should fix the markdown rendering to be a link instead (that's what I see when I preview the MD file in GitHub).It looks like unprivileged users can't label new issues, so I'm not sure the
labelurl parameter does anything, but at a minimum this should fix the formatting of the link.Pull request in home-assistant (if applicable): Not Applicable
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.