Skip to content

Grammatical error fixes #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2016
Merged

Conversation

aedorado
Copy link
Contributor

@aedorado aedorado commented Oct 6, 2016

Github shows one commit on the next branch and 70 on the current branch. Can someone please point out if I am doing something wrong?

@mention-bot
Copy link

@aedorado, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob to be a potential reviewer.

@robbiet480 robbiet480 added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! language-fix labels Oct 7, 2016
@robbiet480 robbiet480 changed the base branch from next to current October 7, 2016 01:09
@robbiet480 robbiet480 changed the base branch from current to next October 7, 2016 01:09
@Landrash
Copy link
Contributor

Landrash commented Oct 7, 2016

@aedorado Your branch of the repository was created against the wrong branch :)
The current branch is a bit ahead on somethings right now since there's very many small fixes being submitted.

@aedorado
Copy link
Contributor Author

aedorado commented Oct 7, 2016

Thanks @Landrash ! I don't think I did something wrong! Did I fork from the wrong branch? Can you please suggest a fix?

@Landrash
Copy link
Contributor

Landrash commented Oct 8, 2016

You most likely made your branch from the wrong branch yes. In this case it's not really a problem since we can merge it into next and there's a release fairly imminent.

@Landrash Landrash merged commit 1fe88fb into home-assistant:next Oct 8, 2016
@aedorado
Copy link
Contributor Author

aedorado commented Oct 8, 2016

@Landrash - Thank you. Can you please tell me how I can become an active part of the home-assistant project. I've been looking to contribute to open-source and I really like the connected home and devices idea. :)

@Landrash
Copy link
Contributor

Landrash commented Oct 8, 2016

@aedorado Jump on gitter, join the community or just review code here and help whoever you can.

I would suggest you start with getting your setup up to the standard you want, ask for help and in that way learn what you need and when possible help those with questions that you can answer.

@aedorado
Copy link
Contributor Author

aedorado commented Oct 8, 2016

@Landrash - Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants