Skip to content

Ecobee formatting fixes #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2015
Merged

Ecobee formatting fixes #117

merged 2 commits into from
Dec 1, 2015

Conversation

nkgilley
Copy link
Contributor

@nkgilley nkgilley commented Dec 1, 2015

I fired up a rake preview for the first time and noticed some formatting issues that this PR should fix.
There is one other issue that I couldn't figure out how to fix: On the components/sensor.ecobee page, the sidebar shows 2 related components that are both called 'Ecobee thermostat'. One should be 'Ecobee' and the other should be 'Ecobee thermostat'. The related components section is correct on the other 2 ecobee pages.

@nkgilley nkgilley changed the title Ecobee Ecobee formatting fixes Dec 1, 2015
@balloob
Copy link
Member

balloob commented Dec 1, 2015

It looks for component pages that have same name and takes those page titles. In your case ecobee.markdown, thermostat.ecobee.markdown and sensor.ecobee.markdown

@nkgilley
Copy link
Contributor Author

nkgilley commented Dec 1, 2015

This PR has the correct titles so not sure why it's not updating in my rake preview.

balloob added a commit that referenced this pull request Dec 1, 2015
@balloob
Merge pull request #117 from nkgilley/ecobee
7cfda23 
Ecobee formatting fixes
@balloob balloob merged commit 7cfda23 into home-assistant:master Dec 1, 2015
@balloob
Copy link
Member

balloob commented Dec 1, 2015

Could be because it does incremental changes, doesn't rerender every page,
just the changed one. Running 'jekyll serve' should render it all. Anyway,
that should be fixed when i release so I'll just merge this.

On Tue, Dec 1, 2015 at 8:35 AM, Nolan Gilley notifications@github.com
wrote:

This PR has the correct titles so not sure why it's not updating in my
rake preview.

—
Reply to this email directly or view it on GitHub
#117 (comment)
.

PaulusSchoutsen.nl
It's nice to be important but it's more important to be nice.

@coderabbitai coderabbitai bot mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkgilley @balloob