contributes to #1055 updates related to Hassbian Image install #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instantchow
commented
Oct 9, 2016
- Fixed a typo on Rasbian getting started page as well as adding how to change hostname
- Adding git as a requirement, don't assume you have it, ex. Hassbian Image 1.0.
running thru a clean hassbian image install, no Git in it, and likely no Git in others, might as well specify installing it before calling a git clone
|
@instantchow, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @Landrash and @turbokongen to be potential reviewers. |
Landrash
requested changes
Oct 9, 2016
There was a problem hiding this comment.
If you could separate this out it would be a good thing.
The changing of hostname really shouldn't be in that list since it not a must do.
We can add that further down with system management and updating.
I'll add it to my list of rewrites.
The change to the ozw docs should be good to go.
|
Similar changes where merged into the documentation with #1262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.