Skip to content

Include documentation for recursive config include #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Include documentation for recursive config include #1216

merged 1 commit into from
Oct 19, 2016

Conversation

lwis
Copy link
Member

@lwis lwis commented Oct 12, 2016

@mention-bot
Copy link

@lwis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bassclarinetl2, @dale3h and @robbiet480 to be potential reviewers.

@Landrash Landrash added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 12, 2016
Copy link
Member

@dale3h dale3h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. A few changes and we will be good to go!


```bash
.
└── config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change config to .homeassistant since it is the default name for the config directory.

@@ -196,6 +196,22 @@ We offer four advanced options to include whole directories at once.
- `!include_dir_merge_list` will return the content of a directory as a list by merging all files (which should contain a list) into 1 big list.
- `!include_dir_merge_named` will return the content of a directory as a dictionary by loading each file and merging it into 1 big dictionary.

These work recursively, for example;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a colon (:) instead of a semi-colon (;).

These work recursively, for example:

@@ -377,7 +393,7 @@ automation: !include_dir_merge_list automation/
action:
service: light.turn_on
entity_id: light.entryway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well add line breaks to the other examples while you're in here making changes. 😉

@lwis
Copy link
Member Author

lwis commented Oct 15, 2016

@dale3h made all the changes, and my editor removes superfluous whitespace on line ends - which is why that line break was highlighted. I've removed it to be consistent with other examples.

│   ├── say_hello.yaml
│   └── sensors
│   └── react.yaml
└── configuration.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this one - or add (not included) at the end

@@ -196,6 +196,22 @@ We offer four advanced options to include whole directories at once.
- `!include_dir_merge_list` will return the content of a directory as a list by merging all files (which should contain a list) into 1 big list.
- `!include_dir_merge_named` will return the content of a directory as a dictionary by loading each file and merging it into 1 big dictionary.

These work recursively, for example:
Copy link
Member

@kellerza kellerza Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

These work recursively. As an example using !include_dir_merge_* automation, will include all 6 files shown below:

@kellerza
Copy link
Member

Should please be part of 0.31 #1263

@lwis
Copy link
Member Author

lwis commented Oct 19, 2016

@kellerza done!

@kellerza kellerza merged commit 96906eb into home-assistant:next Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants