Skip to content

Adding Concord232 Details #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2016
Merged

Conversation

JasonCarter80
Copy link
Contributor

@JasonCarter80 JasonCarter80 commented Oct 12, 2016

Adding Concord232 documentation to coincide with

home-assistant/core#3842


```yaml
# Example configuration.yaml entry
alarm_control_panel:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the binary sensor and control panel share the same configuration if so you could just indicate this on the page like this. If not then this line should be binary_sensor:

footer: true
logo: networx.png
ha_category: Alarm
ha_release: 0.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.31 or later.

footer: true
logo: networx.png
ha_category: Alarm
ha_release: 0.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.31 or later.

ha_release: 0.13
---

The `concord232` platform provides integration with GE, Interlogix (and other brands) alarm panels that support the RS-232 Automation Control Panel interface module (or have it built in). Supported panels include Concord 4. Actual integration is done through [concord232](http://github.com/JasonCarter80/concord232) which is required for this to work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space after "GE, "

ha_release: 0.13
---

The `concord232` platform provides integration with GE, Interlogix (and other brands) alarm panels that support the RS-232 Automation Control Panel interface module (or have it built in). Supported panels include Concord 4. Actual integration is done through [concord232](http://github.com/JasonCarter80/concord232) which is required for this to work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space after "Ge, "

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor concerns but all in all looks good.

@robbiet480 robbiet480 added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 13, 2016
@fabaff fabaff dismissed Landrash’s stale review October 22, 2016 08:45

I will fix the remaining issues if needed.

@fabaff fabaff merged commit dff002f into home-assistant:next Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants