Skip to content

Sets Lovelace button entity configuration variable to optional #12465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pedrolamas
Copy link
Contributor

Proposed change

Since the change home-assistant/frontend#4581, the entity is not required anymore for the Lovelace button, but documentation still says it does: https://www.home-assistant.io/lovelace/button/#entity

This updated the documentation by replacing the "(Required)" label with "(Optional)" and also updates the sample to show this change.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo current This PR goes into the current branch labels Mar 20, 2020
@frenck
Copy link
Member

frenck commented Mar 21, 2020

@bramkragten Tagged you for review. Could you take a look? Thanks! 👍

@frenck
Copy link
Member

frenck commented Mar 22, 2020

Thanks, @pedrolamas! 👍

@frenck frenck merged commit c5b7ddb into home-assistant:current Mar 22, 2020
@pedrolamas pedrolamas deleted the pedrolamas/lovelace-button branch March 24, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants