Skip to content

Add supported services #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2016
Merged

Add supported services #1249

merged 4 commits into from
Nov 18, 2016

Conversation

jnimmo
Copy link
Contributor

@jnimmo jnimmo commented Oct 15, 2016

To document the new alarm_keypress and alarm_output_control services in PR home-assistant/core#3932.

To document the new alarm_keypress and alarm_output_control services
@mention-bot
Copy link

@jnimmo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Cinntax and @fabaff to be potential reviewers.

@fabaff fabaff added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 15, 2016
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small addition I think should be made but looks good with that exception.

@@ -69,3 +69,11 @@ Configuration variables:
- **zones** (*Optional*): Envisalink boards have no way to tell us which zones are actually in use, so each zone must be configured in Home Assistant. For each zone, at least a name must be given. *Note: if no zones are specified, Home Assistant will not load any binary_sensor components.*
- **partitions** (*Optional*): Again, Envisalink boards do not tell us what is in use and what is not, so each partition must be configured with a partition name. If no partition parameter is specified, then no alarm_panel or sensor components are loaded.

Supported services:

- **alarm_disarm**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need some descriptive text also. Looks very bare and like it's missing without.

@jnimmo
Copy link
Contributor Author

jnimmo commented Oct 20, 2016

Thanks @Landrash, hopefully this is a bit more descriptive?

@Landrash
Copy link
Contributor

Looks good. Changed your description to point to the new pull request.
Can be merged when the related pull request is merged! 🍪

@Landrash Landrash modified the milestone: 0.32 Oct 23, 2016
@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Oct 23, 2016
@robbiet480 robbiet480 removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 1, 2016
@Landrash
Copy link
Contributor

@jnimmo I'm assuming your merged pull request is correct with this documentation? If so I'll merge this one.

@jnimmo
Copy link
Contributor Author

jnimmo commented Nov 18, 2016

Thanks @Landrash - yes it is all correct now. Cheers

@Landrash Landrash merged commit 44c12e1 into home-assistant:current Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants