Skip to content

Add examples of events #12534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2020
Merged

Add examples of events #12534

merged 2 commits into from
Mar 29, 2020

Conversation

gerard33
Copy link
Contributor

@gerard33 gerard33 commented Mar 28, 2020 •
edited
Loading

Proposed change

As discussed with @cgtobi in https://community.home-assistant.io/t/netatmo-in-ha-0-105/169377/133?u=gerard33

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 28, 2020
@cgtobi
Copy link
Contributor

cgtobi commented Mar 28, 2020

Good point @gerard33. Could we make this a second example as movement is valid for indoor/welcome cameras?

@gerard33
Copy link
Contributor Author

Sure thing, added it as a second example.

cgtobi
cgtobi approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gerard33

frenck
frenck approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gerard33! 👍

@frenck frenck merged commit f495cff into home-assistant:current Mar 29, 2020
@gerard33 gerard33 deleted the patch-1 branch March 29, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

@cgtobi cgtobi cgtobi approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerard33 @cgtobi @frenck