Clear sleep timers #1273
Merged
Clear sleep timers #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@americanwookie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @andreasjacobsen93 to be potential reviewers. |
6 tasks
Landrash
requested changes
Oct 20, 2016
|
|
||
| ### {% linkable_title Service `sonos_clear_sleep_timer` %} | ||
|
|
||
| Clear, that is, cancel the sleep timer on a speaker, if one is set. |
There was a problem hiding this comment.
I'm a bit uncertain about the structure of this sentence.
Clear the sleep time on a speaker, if one is set.
Should be enough.
There was a problem hiding this comment.
That's great advice, thanks! Fix has been force push'd.
27d734d to
3ba8c66
Compare
Landrash
approved these changes
Oct 20, 2016
|
Looks good 🍸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I added a service to set a sleep timer, but there's no way to clear it! Oops, this fixes that.
Pull request in home-assistant (if applicable): home-assistant/core#3941