Add documentation for Bbox Sensors #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Landrash
requested changes
Oct 22, 2016
|
|
||
| <p class='note warning'> | ||
| Due to third party limitation, the sensors will only be available if the HomeAssistant and the Bbox are on the same local area network. | ||
| You can check this by going on the 192.168.1.254 address with your internet browser |
There was a problem hiding this comment.
I would repleace internet browser with Web browser. Also missing a ".".
| Sensors are mainly bandwidth measures (Details below) | ||
|
|
||
| <p class='note warning'> | ||
| Due to third party limitation, the sensors will only be available if the HomeAssistant and the Bbox are on the same local area network. |
There was a problem hiding this comment.
HomeAssistant -> Home Assistant .
|
|
||
| - **monitored_variables** array (*Required*): Sensors to display in the frontend. | ||
| - **down_max_bandwidth**: Maximum bandwidth you can use for downloading. | ||
| - **up_max_bandwidth**: Maximum bandwidth you can use for uploadinf. |
| Configuration variables: | ||
|
|
||
| - **monitored_variables** array (*Required*): Sensors to display in the frontend. | ||
| - **down_max_bandwidth**: Maximum bandwidth you can use for downloading. |
There was a problem hiding this comment.
I would probably rephrase this from
Maximum bandwidth you can use for downloading.
To
Maximum bandwidth available for download.
|
|
||
| - **monitored_variables** array (*Required*): Sensors to display in the frontend. | ||
| - **down_max_bandwidth**: Maximum bandwidth you can use for downloading. | ||
| - **up_max_bandwidth**: Maximum bandwidth you can use for uploadinf. |
There was a problem hiding this comment.
I would probably rephrase this from
Maximum bandwidth you can use for uploading.
To
Maximum bandwidth available for upload.
|
Will fix the comments by @Landrash after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Documentation for Bbox Sensors
Pull request in home-assistant (if applicable): home-assistant/core#3956