Skip to content

Converting unit_of_measurement variable to optional, to be consisten with other sensors #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

bestlibre
Copy link
Contributor

Description:
On the other sensors, unit of measurement is an optional configuration variable. It should be the same for influxdb sensor.

Pull request in home-assistant (if applicable): home-assistant/core#4076

@mention-bot
Copy link

@bestlibre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff to be a potential reviewer.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit a1e5682 into home-assistant:next Oct 27, 2016
@bestlibre bestlibre deleted the influxdb_optional_unit branch October 28, 2016 06:43
@robbiet480 robbiet480 added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants