Add sensor types to Envisalink binary sensor docs #1346
Conversation
|
@wingrunr21, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @Cinntax to be potential reviewers. |
| The requirement is that you have setup your [Envisalink hub](/components/envisalink/). | ||
|
|
||
| #### Sensor Types |
There was a problem hiding this comment.
It is already documented at https://home-assistant.io/components/binary_sensor/
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, I missed that documentation somehow. What're your thoughts on removing the Envisalink binary sensor docs and directly linking there instead? There doesn't appear to be anything specialized about the Envisalink binary sensor that the general component docs don't cover. The zones area can include the link/documentation to the sensor type similar to how the CLI binary sensor does it.
There was a problem hiding this comment.
I picked some of your changes and introduced them with #1396.
There was a problem hiding this comment.
No, we can't remove the Envisalink binary sensor docs because we are linking from the configuration check to the docs.
* Link to binary sensor docs for sensor_class * Include link to sensor_class (fixes #1346)
I recently set up this component and had to dig into the source to find these types. Figured dropping them into the docs directly might save some people some time in the future.