Skip to content

Update manual.markdown #13463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2020
Merged

Update manual.markdown #13463

merged 1 commit into from
May 16, 2020

Conversation

SamyGarib
Copy link
Contributor

@SamyGarib SamyGarib commented May 16, 2020

The alarm code, when presented as number and starts with 0 does not work as intended (because math). I propose to quote it in the example so people won't have headaches like me. This is my favorite piece of software so far. Please keep up this amazing work.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

The alarm code, when presented as number and starts with 0 does not work as intended (because math). I propose to quote it in the example so people won't have headaches like me. This is my favorite piece of software so far. Please keep up this amazing work.
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label May 16, 2020
@SamyGarib
Copy link
Contributor Author

I'm not sure I did everything right even though I just added quotes. I hope I had helped.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SamyGarib 👍

@frenck frenck merged commit 8383bfd into home-assistant:current May 16, 2020
@SamyGarib SamyGarib deleted the patch-1 branch May 16, 2020 18:58
rikroe pushed a commit to rikroe/home-assistant.io that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants