-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add demo link. #13667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo link. #13667
Conversation
What should I do to make this PR continue ? |
I've looked at the demo and it looks cool. But it exposes IP addresses of anyone who as checked it out, viewable by anybody. This is a privacy issue. |
I think, as an alternative approach, a screenshot can be added. |
This test account has guest rights only,it can view and operate the light to see the power meter changes only. |
@lewei50 Yes there is, as you can view all access tokens in the user account and thus see all IP addresses of people logged into the demo. Please use a screenshot instead. |
Thanks for your expaination.I'll attach a screenshot . |
I have replaced the url to a snapshot. |
I have uploaded the snapshot to ../images/snapshots/ directory and reedited the markdown file. |
Co-authored-by: Zack Arnett <arnett.zackary@gmail.com>
Proposed change
Add demo link.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.