Skip to content

Add demo link. #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 3, 2020
Merged

Add demo link. #13667

merged 10 commits into from
Aug 3, 2020

Conversation

lewei50
Copy link
Contributor

@lewei50 lewei50 commented Jun 5, 2020

Proposed change

Add demo link.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jun 5, 2020
@lewei50
Copy link
Contributor Author

lewei50 commented Jun 19, 2020

What should I do to make this PR continue ?

@frenck
Copy link
Member

frenck commented Jun 19, 2020

I've looked at the demo and it looks cool. But it exposes IP addresses of anyone who as checked it out, viewable by anybody. This is a privacy issue.

@frenck
Copy link
Member

frenck commented Jun 19, 2020

I think, as an alternative approach, a screenshot can be added.

@lewei50
Copy link
Contributor Author

lewei50 commented Jun 22, 2020

This test account has guest rights only,it can view and operate the light to see the power meter changes only.
The demo environment is isolated,so there is no risk to expose any devices's IP.
Operating the real lights will give guest better experience in HA I think.

@frenck
Copy link
Member

frenck commented Jun 22, 2020

@lewei50 Yes there is, as you can view all access tokens in the user account and thus see all IP addresses of people logged into the demo.

Please use a screenshot instead.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jun 22, 2020
@lewei50
Copy link
Contributor Author

lewei50 commented Jun 23, 2020

@lewei50 Yes there is, as you can view all access tokens in the user account and thus see all IP addresses of people logged into the demo.

Please use a screenshot instead.

Thanks for your expaination.I'll attach a screenshot .

@lewei50
Copy link
Contributor Author

lewei50 commented Jun 23, 2020

I have replaced the url to a snapshot.
Thanks a lot.

@lewei50
Copy link
Contributor Author

lewei50 commented Jun 24, 2020

I have uploaded the snapshot to ../images/snapshots/ directory and reedited the markdown file.
wish it works.

@frenck frenck self-assigned this Jul 14, 2020
@frenck frenck merged commit 9932cd7 into home-assistant:current Aug 3, 2020
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants