Update switch.command_line friendly_name behavior #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`switch.command_line` will now always use `object_id` for `entity_id`, even if `friendly_name` is given. home-assistant/core#3434 home-assistant/core#4343 How interesting -- issue 3434 and PR 4343.
|
@n8henrie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @joemcmonagle to be potential reviewers. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After the below PR gets merged into master,
switch.command_linewill always useobject_idforentity_id, even iffriendly_nameis given. To me the docs seemed to suggest this behavior previously (though it's not how things worked); this adds clarification.Pull request in home-assistant (if applicable): home-assistant/core#4343
switch.command_linewill now always useobject_idforentity_id, even iffriendly_nameis given.home-assistant/core#3434
home-assistant/core#4343
How interesting -- issue 3434 and PR 4343.