Skip to content

Zwave documentation update #14485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 15, 2020
Merged

Zwave documentation update #14485

merged 8 commits into from
Oct 15, 2020

Conversation

Nimzr
Copy link
Contributor

@Nimzr Nimzr commented Sep 13, 2020

Proposed change

Updating zwave portion of the documentation with minor adjustments:

  • Adding recommendation to disenroll a device before attempting to add to the network since this could save hours of annoyance.
  • Minor updates the removing devices sections
  • Minor update to the network key section
  • Updates are in /_docs/z-wave/adding.markdown & /_docs/z-wave.markdown

Type of change

  • [x ] Spelling, grammar or other readability improvements (current branch).
  • [x ] Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • [x ] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x ] The documentation follows the Home Assistant documentation standards.

Nimzr added 2 commits September 12, 2020 19:43
added reference for recommendation to perform an unenrol before adding a device.
also added a reference that the script for the network key is a UNIX command but can easily be ran in Home Assistant.
added reference for recommendation to perform an unenrol before adding a device.
also added a reference that the script for the network key is a UNIX command but can easily be ran in Home Assistant.
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Sep 13, 2020
@Nimzr
Copy link
Contributor Author

Nimzr commented Sep 13, 2020

Good luck! let me know if there is anything I should update or fix :)

removed emphasis off the main recommendation until review is completed
Copy link
Contributor Author

@Nimzr Nimzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed some empty spaces and emphasis.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Sep 14, 2020
Copy link
Contributor Author

@Nimzr Nimzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushing a commit with these updates now.

@Nimzr Nimzr requested a review from frenck September 19, 2020 18:36
Copy link
Contributor Author

@Nimzr Nimzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushing another commit to make final updates

@Nimzr
Copy link
Contributor Author

Nimzr commented Sep 26, 2020

e46da39 submitted or review

@Nimzr
Copy link
Contributor Author

Nimzr commented Oct 10, 2020

Hey @frenck is this waiting for anything on my end? just want to make sure.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Nimzr 👍

Looks good! Sorry for the long wait, it has been crazy busy with Hacktoberfest the past weeks.

Happy Hacktoberfest 😉

@frenck frenck merged commit 60b7b7b into home-assistant:current Oct 15, 2020
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants