Skip to content

Update z-wave.markdown #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2016
Merged

Update z-wave.markdown #1452

merged 2 commits into from
Nov 19, 2016

Conversation

turbokongen
Copy link
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/core#4437

@mention-bot
Copy link

@turbokongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @Landrash and @devdelay to be potential reviewers.

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missing word and one question. Always lovely to see your work on the zwave stuff.

@@ -79,6 +79,8 @@ Configuration variables:
- **customize** (*Optional*): This attribute contains node-specific override values:
- **polling_intensity** (*Optional*): Enables polling of a value and sets the frequency of polling (0=none, 1=every time through the list, 2=every other time, etc). If not specified then your device will not be polled.
- **ignored** (*Optional*): Ignore this entitiy completely. It won't be shown in the Web Interface and no events are generated for it.
- **refresh_value** (*Optional*): Enable refreshing of node value. Only light component uses this. Defaults to 2 second delay.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a "the". Looks good with that exception.

@@ -79,6 +79,8 @@ Configuration variables:
- **customize** (*Optional*): This attribute contains node-specific override values:
- **polling_intensity** (*Optional*): Enables polling of a value and sets the frequency of polling (0=none, 1=every time through the list, 2=every other time, etc). If not specified then your device will not be polled.
- **ignored** (*Optional*): Ignore this entitiy completely. It won't be shown in the Web Interface and no events are generated for it.
- **refresh_value** (*Optional*): Enable refreshing of node value. Only light component uses this. Defaults to 2 second delay.
- **delay** (*Optional*): Specify the delay to wait for refresh of node value if you want other than 2 seconds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plural of values from node or should it be a single value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this specific value for this node.

@fabaff fabaff merged commit 8977fc0 into next Nov 19, 2016
@fabaff fabaff deleted the turbokongen-patch-1 branch November 19, 2016 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants