Clarify disable html5 push notification switch reason #14555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
requested changes
Sep 19, 2020
source/_integrations/html5.markdown
Outdated
| @@ -103,7 +103,7 @@ The `html5` platform can only function if all of the following requirements are | |||
| Assuming you have already configured the platform: | |||
|
|
|||
| 1. Open Home Assistant in Chrome or Firefox. | |||
| 2. Load profile page by clicking on the badge next to the Home Assistant title in the sidebar. Assuming you have met all the [requirements](#requirements) above then you should see a new slider for Push Notifications. If the slider is greyed out, ensure you are viewing Home Assistant via its external HTTPS address. If the slider is not visible, ensure you are not in the user configuration (Sidebar, Configuration, Users, View User). | |||
| 2. Load profile page by clicking on the badge next to the Home Assistant title in the sidebar. Assuming you have met all the [requirements](#requirements) above then you should see a new slider for Push Notifications. If the slider is greyed out, ensure you are viewing Home Assistant via its external HTTPS address (or that you have configured the `notify` HTML5 integration in Home Assistant). If the slider is not visible, ensure you are not in the user configuration (Sidebar, Configuration, Users, View User). | |||
There was a problem hiding this comment.
or that you have configured the notify HTML5 integration in Home Assistant is that a "or"?
There was a problem hiding this comment.
you're right, it required anyway. I've updated the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I've just followed the integration for HTML5 Push Notification and wasn't able to finish the setup because the button was still disable. So if you strcitly follow the documentation, you cannot enable the Push Notification in the user profil because the integration has not been added to the
configuration.yaml.Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Checklist
currentbranch.nextbranch.