Skip to content

Add support for light effects in mqtt_template #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2016
Merged

Add support for light effects in mqtt_template #1489

merged 2 commits into from
Dec 4, 2016

Conversation

Diaoul
Copy link
Contributor

@Diaoul Diaoul commented Nov 23, 2016

Description: Add support for light effects in mqtt_template

Pull request in home-assistant (if applicable): home-assistant/core#4538

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good in general with two small exceptions.
Fix those and this can be merged as soon as the parent pr is merged.

@@ -2,22 +2,22 @@
layout: page
title: "MQTT Template Light"
description: "Instructions for how to setup MQTT Template lights within Home Assistant."
date: 2016-11-06 21:16
date: 2016-11-23 23:14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date should not change since the page is updated and not not created.

sidebar: true
comments: false
sharing: true
footer: true
logo: mqtt.png
ha_category: Light
ha_iot_class: "Local Push"
ha_release: 0.33
ha_release: 0.34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha_release refers to the version of Home Assistant that the component was introduced. Since this is just an addition to a component there's no need to change this.

@Landrash Landrash merged commit fe91174 into home-assistant:next Dec 4, 2016
trisk pushed a commit to trisk/home-assistant.github.io that referenced this pull request Dec 7, 2016
* Add support for light effects in mqtt_template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants