Skip to content

Added documentation for flic smart button component. #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2016

Conversation

soldag
Copy link
Contributor

@soldag soldag commented Dec 3, 2016

Description:
Added documentation for flic smart button component.

Pull request in home-assistant (if applicable): home-assistant/core#4681

@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label Dec 3, 2016
Fixed capital letters of Home Assistant.
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one small comment.
Also fixed a small formatting error.
Looks good in general and can be merged after this is fixed and parent pr is merged.


Configuration variables:

- **host** (*Optional*): The IP of the flic service server. (default: `localhost`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "IP or hostname". Example even includes the hostname of localhost.

@soldag
Copy link
Contributor Author

soldag commented Dec 4, 2016

@Landrash I updated the documentation.

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and can be merged after parent is merged. 🍸

@emlove
Copy link
Contributor

emlove commented Dec 5, 2016

Can you include an example automation making use of the new events? See https://home-assistant.io/components/lirc/ for an example.

@soldag
Copy link
Contributor Author

soldag commented Dec 5, 2016

@armills Done 😉

Renamed ‘auto_scan’ to ‘discovery’.
@Landrash Landrash merged commit 9fba415 into home-assistant:next Dec 6, 2016
trisk pushed a commit to trisk/home-assistant.github.io that referenced this pull request Dec 7, 2016
@soldag
Copy link
Contributor Author

soldag commented Dec 7, 2016

@fabianbergmark I created the new PR #1556 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants