Skip to content

Add counter and timer to default_config #15455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2020
Merged

Add counter and timer to default_config #15455

merged 2 commits into from
Oct 29, 2020

Conversation

andriej
Copy link
Contributor

@andriej andriej commented Oct 29, 2020

Proposed change

Intoduced in 0.117, mentioned in UI, not mentioned in docs.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@andriej
Add counter to default_config
a7b0247 
Intoduced in 0.117, mentioned in UI, not mentioned in docs.
@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 29, 2020
@andriej andriej changed the title Add counter to default_config Add counter and timer to default_config Oct 29, 2020
frenck
frenck approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andriej 👍

Happy Hacktoberfest 🎉

@frenck frenck merged commit 2becc35 into home-assistant:current Oct 29, 2020
@andriej andriej deleted the patch-5 branch October 29, 2020 11:16
caronc pushed a commit to caronc/home-assistant.io that referenced this pull request Oct 30, 2020
@andriej @caronc
Add counter and timer to default_config (home-assistant#15455)
22c31e7
nzapponi pushed a commit to nzapponi/home-assistant.io that referenced this pull request Nov 5, 2020
@andriej @nzapponi
Add counter and timer to default_config (home-assistant#15455)
125308c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andriej @frenck