Skip to content

Conversation

craigjmidwinter
Copy link
Contributor

@craigjmidwinter craigjmidwinter commented Dec 18, 2016

Description: Add documentation for Insteon Local component

Pull request in home-assistant (if applicable): home-assistant/core#5088

@craigjmidwinter craigjmidwinter changed the title Insteon local WIP: Insteon local Dec 18, 2016
@craigjmidwinter craigjmidwinter changed the title WIP: Insteon local Insteon local Dec 18, 2016
@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Dec 20, 2016
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback but in general a really good piece of documentation.

host: YOUR HUB IP
username: YOUR HUB USERNAME
password: YOUR HUB PASSWORD
# Example configuration.yaml light entry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Suggest adding a line break in-between examples.

username: YOUR HUB USERNAME
password: YOUR HUB PASSWORD
# Example configuration.yaml light entry
light:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light and switch examples should be excluded from this file.
Optionally have a basic example and a full configuration example.


Configuration variables:

- **username** (*Required*): The username used to access the Insteon interface (find in your insteon app).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insteon should probably be Insteon.

footer: true
logo: insteon.png
ha_category: Hub
ha_iot_class: "Local Polling"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha_version: tag will need to be added to all new files to reflect the version the component was added in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Landrash! ha_version should be add to the other pages as well

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff dismissed Landrash’s stale review January 14, 2017 15:34

Need to merge it.

@fabaff fabaff merged commit c2b0a70 into home-assistant:next Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants