Skip to content

Merge documentation update for PR 4981 #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Merge documentation update for PR 4981 #1652

wants to merge 9 commits into from

Conversation

Duoxilian
Copy link
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

@mention-bot
Copy link

@Duoxilian, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @skyval and @Danielhiversen to be potential reviewers.

@Duoxilian
Copy link
Contributor Author

I am not sure whether I did this right, because I don't see my changes in the list above. For what it is worth, I updated components.climate on fork duoxilian, 12389ec.

@MartinHjelmare
Copy link
Member

Yeah, something is not right with this branch. I can try to pull your commit and push it upstream. I'll see what I can do. Your changes look good.

@MartinHjelmare
Copy link
Member

@Duoxilian there's a tutorial how to do the PR here:
#1052

Only difference is that you should change branch to next first before editing the page. The PR should also target next.

It looks as your existing commit is orphaned on github, cause I can't find any way of fetching it to my local repo.

@Duoxilian
Copy link
Contributor Author

Thanks. The trick was going to next first.

@Duoxilian Duoxilian closed this Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants