Skip to content

Conversation

b0g3r
Copy link
Contributor

@b0g3r b0g3r commented Feb 27, 2021

Proposed change

Original App for xiaomi vacuum has nice feature of room cleaning with repetition. Despite the fact that the protocol does not support repetition for segment cleaning (proof) user can use a special workaround with repetition of segment id. I think it's a very useful example of integration usage, so it should be somewhere in the documentation about service.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@homeassistant
Copy link

Hi @b0g3r,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Feb 27, 2021
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 1, 2021
b0g3r and others added 2 commits March 13, 2021 16:26
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@b0g3r b0g3r requested a review from frenck March 13, 2021 13:31
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @b0g3r 👍

@frenck frenck merged commit 6d01d72 into home-assistant:current Mar 15, 2021
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Mar 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants