Skip to content

Remove YAML optionals from Sighthound config example #16808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Remove YAML optionals from Sighthound config example #16808

merged 2 commits into from
Mar 2, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 2, 2021 •
edited
Loading

Proposed change

Removes optional configuration keys from the initial example, additionally, corrects a type in the configuration block.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 2, 2021
@frenck frenck mentioned this pull request Mar 2, 2021
Closed
@frenck frenck mentioned this pull request Mar 2, 2021
Merged
8 tasks
@probot-home-assistant

This comment has been minimized.

Sign in to view
@frenck frenck removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch has-parent This PR has a parent PR in a other repo labels Mar 2, 2021
klaasnicolaas
klaasnicolaas approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@klaasnicolaas klaasnicolaas merged commit 4857724 into current Mar 2, 2021
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the frenck-2021-0762 branch March 2, 2021 20:05
Nick-Adams-AU pushed a commit to Nick-Adams-AU/home-assistant.io that referenced this pull request Mar 3, 2021
@frenck @Nick-Adams-AU
Remove YAML optionals from Sighthound config example (home-assistant#…
6d2f5b4 
…16808)

* Remove YAML defaults from Sighthound config example

* Add default value
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klaasnicolaas klaasnicolaas klaasnicolaas approved these changes

Assignees

@frenck frenck

Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sighthound integration throws error using documented example
3 participants
@frenck @klaasnicolaas @homeassistant