Skip to content

Update verisure documentation for 2fa bug #17013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 15, 2021
Merged

Update verisure documentation for 2fa bug #17013

merged 13 commits into from
Mar 15, 2021

Conversation

martycochrane
Copy link
Contributor

Proposed change

Verisure added some new 2FA rules and I've added documentation to help users with a workaround until their third party integration works better with Homeassistant

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@homeassistant
Copy link

Hi @martycochrane,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 15, 2021
@martycochrane
Copy link
Contributor Author

Sorry, I see the text linting has failed. I'll fix it now

frenck
frenck requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally; please make sure sentences end with a full stop (.), even in lists.

source/_integrations/verisure.markdown Outdated
@@ -138,3 +138,16 @@ automation:
| disable_autolock | Disables autolock function for a specific lock. |
| enable_autolock | Enables autolock function for a specific lock. |
| smartcam_capture | Capture a new image from a specific smartcam. |

## 2 Factor Authentication Workaround
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a prerequisite, let's put it above the configuration section and call it as such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it now and renamed the title. Do you think the location and new title is ok?

source/_integrations/verisure.markdown Outdated
2. Make sure that user is admin, you've logged in & setup 2fa
3. Login as the home assistant user, browse to Account and subscription -> Account -> Login Credentials -> Disable 2fa

**Note this will only be available if the user is admin and has logged in once with 2fa, logged out and in again**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to add notes to our documentation:

https://developers.home-assistant.io/docs/documenting/create-page#html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to the correct format now. Thanks for sharing this, I missed this section on notes.
I had to do it inline to stop any markdown linting errors. Is this ok?

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 15, 2021
frenck
frenck reviewed Mar 15, 2021
View reviewed changes
This was referenced Mar 15, 2021
Merged
Closed
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in another repo label Mar 15, 2021
frenck
frenck reviewed Mar 15, 2021
View reviewed changes
source/_integrations/verisure.markdown Outdated
Comment on lines 113 to 118
1. Log in to Verisure My Pages as your admin user and create a new admin user for Home Assistant.
2. Log in in as your newly created Home Assistant user, you'll be prompted to set up 2FA, do that and then log out. This will make sure the options below are available.
3. Log in as the Home Assistant user, browse to Account and subscription -> Account -> Login Credentials -> Disable 2FA.<div class='note warning'>This will only be available if the user is admin and has logged in once with 2FA, logged out and in again.</div>
4. Log in as your administrator again and change the Home Assistant user to a restricted user.
5. Change Home Assistant Verisure config to the new user credentials in Home Assistant.
6. Restart Home Assistant.
Copy link
Member

@frenck frenck Mar 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good news it... as of 2021.4, that isn't needed anymore 😉 (the restart that is)

frenck
frenck approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @martycochrane 👍

@frenck frenck merged commit 2a84f1e into home-assistant:current Mar 15, 2021
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Mar 15, 2021
@martycochrane martycochrane deleted the verisureDocUpdate branch March 16, 2021 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@martycochrane martycochrane

Labels
cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in another repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martycochrane @homeassistant @frenck