Skip to content

Bom weather docs #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2017
Merged

Bom weather docs #1703

merged 1 commit into from
Jan 15, 2017

Conversation

Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Jan 3, 2017 •
edited
Loading

I've been working on BOM weather information, now that there's a new weather component. This is the corresponding docs for home-assistant/core#5153

@mention-bot
Copy link

@Zac-HD, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @fnoorian and @tinglis1 to be potential reviewers.

@Zac-HD Zac-HD mentioned this pull request Jan 3, 2017
Merged
3 tasks
fnoorian
fnoorian suggested changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@fnoorian fnoorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zac-HD,

Excellent job. Can you fix these too:

  • In both commits, change an source to a source.
  • At the end of both, you have a html type <p> section. Convert this to markdown too.

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Jan 3, 2017

Thanks 😄

I've fixed the typos, but it seems that in markdown this is the only way to write a note block. The same pattern is used in (eg) sensor.octoprint, the old sensor.bom page, getting-started/z-wave, etc. If there is a better way I'd love to hear about it!

fnoorian
fnoorian approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@fnoorian fnoorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I mistook Mardown with DocOnce :-|

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Jan 6, 2017

Rebased, with minor edits to stay current with the main pull request.

@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label Jan 6, 2017
fabaff
fabaff approved these changes Jan 15, 2017
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :birds:

@fabaff fabaff merged commit 3696c00 into home-assistant:next Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

+1 more reviewer

@fnoorian fnoorian fnoorian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zac-HD @mention-bot @fabaff @fnoorian