Skip to content

Add integration doc for Leviosa_Shades #17063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

altersis
Copy link

@altersis altersis commented Mar 19, 2021

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 19, 2021
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label Mar 19, 2021
@klaasnicolaas klaasnicolaas removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Mar 19, 2021
@altersis
Copy link
Author

altersis commented Mar 19, 2021

Hey there. I'm sorry but I don't understand what is happening here. I originally created #17062, using current as the source branch and next as the target, then was asked to rebase it on dev. I decided to close #17062, as only one file was added, and I believe what I did produces the same result. the probot is asking for a rebase, but wouldn't that takes us to the original problem?

@altersis altersis removed their assignment Mar 19, 2021
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label Mar 19, 2021
@klaasnicolaas
Copy link
Member

klaasnicolaas commented Mar 19, 2021

Probot never asks you to rebase to dev 🤷‍♂️ but the problem is that next and current are 2 different branches. current is for changes independent of the releases, while next is always linked to a pull request in the core repository.

Wanting to merge a current branch (by means of a PR) in next then causes problems. But now it has gone well! 🚀

Thanks you so much for taking the time to enhance this document, I really appreciate your help!
@altersis
Copy link
Author

Changes applied as requested. Thanks for your help!

Copy link
Author

@altersis altersis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help! I hope all is ok now.

- If you have more than one Leviosa Zone in your Network, Home Assistant will display a list, with one IP address for each Leviosa Zone discovered, in the same order as they were discovered. Once a Leviosa Zone is configured in Home Assistant, it will not appear in this list. Refer to the next section to find the IP address of each zone group.
- If you have only one Leviosa Zone, then you'll be taken directly to the screen to enter the Leviosa Zone name and shade group names.
- You can name the shade groups as you wish. They do not have to match the names already in the Leviosa App.
- A `cover` entity for each shade group will be ready for you. An additional `cover` entity is created with the name of the zone (prefixed `all_`) to move all groups in a Leviosa Zone at the same time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional all_ group/entity should not be created. It is not the responsibility of integration to provide that.

Copy link
Author

@altersis altersis Apr 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! thank you for taking a look at this. I would like to clarify that the Leviosa Zone can handle 6 shade groups, plus a special group (called Group 0 in the Leviosa Zone hub) that allows moving all Blind groups up or down. The additional shade group 'all' is just a way to expose this Group 0 functionality to the user, otherwise there would not be a way to use it. If after this explanation this appears incorrect, could you please help me to understand how the Group 0 should be exposed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should not be exposed? They can be grouped in Home Assistant if one wishes to do so.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, and I agree that all shade groups could be grouped; that would produce a different user experience. I'll explain: Group 0 commands all shades to move at exactly the same time, using only one RF command over the air. All motors react to this command immediately, as they all belong to Group 0 in addition to their configured group. If I understand HASS grouping correctly, HASS would send a command to each Group in the Leviosa Zone in rapid succession, which would start raising the shades at different times, possibly with a different order each time. This happens because the Zone would send multiple RF commands over the air, one for each shade group (RF transmission is slow, so it takes about 100 ms per command). I'm sure this behavior would lower the 'wow' factor that is expected from all blinds reacting at exactly the same time. Hope this clarifies why the 'all_' shade group is important for these blinds.

altersis and others added 4 commits April 4, 2021 17:21
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

Not sure about the group thing, but that is something for the code PR to further find out.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Apr 6, 2021
@klaasnicolaas klaasnicolaas added the new-integration This PR adds documentation for a new Home Assistant integration label Apr 6, 2021
@frenck
Copy link
Member

frenck commented Aug 24, 2021

Closing PR as the parent PR has been closed.

@frenck frenck closed this Aug 24, 2021
@probot-home-assistant probot-home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Aug 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants