Skip to content

Add ping docs #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2017
Merged

Add ping docs #1723

merged 2 commits into from
Jan 7, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 6, 2017

Description:
Initial ping device tracker docs.

Pull request in home-assistant (if applicable): home-assistant/core#5176

@michaelarnauts michaelarnauts mentioned this pull request Jan 6, 2017
Merged
8 tasks
@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label Jan 6, 2017
@michaelarnauts
Copy link
Contributor

Nice!
The closing parenthesis of count is missing though.
It might also be better to word the hosts as List of device names and their corresponding IP address or hostname.
This makes it clear that it can do a DNS lookup and that the key is just a identifier.

@fabaff
Copy link
Member Author

fabaff commented Jan 6, 2017

Thanks for your feedback.

@fabaff fabaff merged commit c84fbb2 into next Jan 7, 2017
@fabaff fabaff deleted the ping branch January 7, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @michaelarnauts