Skip to content

Add note about breaking changes to zwave_js section of release notes #17292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2021
Merged

Add note about breaking changes to zwave_js section of release notes #17292

merged 2 commits into from
Apr 5, 2021

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Apr 5, 2021

Proposed change

Beta users are missing the breaking changes section for zwave_js so I added a note to hopefully prevent duplicate no-op issues from getting created.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 5, 2021
@probot-home-assistant probot-home-assistant bot added the rc This PR is against the RC branch label Apr 5, 2021
@raman325 raman325 removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Apr 5, 2021
frenck
frenck reviewed Apr 5, 2021
View reviewed changes
@raman325 @frenck
Update source/_posts/2021-04-07-release-20214.markdown
1c20b04 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@frenck frenck added the blog This PR adds a blog article to the Home Assistant website label Apr 5, 2021
@frenck frenck merged commit 1f93ee1 into home-assistant:rc Apr 5, 2021
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Apr 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
@raman325 raman325 deleted the zwave_js_breaking branch April 28, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@raman325 raman325

Labels
blog This PR adds a blog article to the Home Assistant website cla-signed rc This PR is against the RC branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raman325 @frenck @homeassistant