Skip to content

Heartbeats section added #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2017
Merged

Conversation

brahmafear
Copy link
Contributor

Added basic documentation of smartSleep functionality within HA based on receiving a heartbeat signal form MySensor node.

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Added basic documentation of smartSleep functionality within HA based on receiving a heartbeat signal form MySensor node.
@mention-bot
Copy link

@brahmafear, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MartinHjelmare and @balloob to be potential reviewers.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See inline comments.

@@ -171,6 +171,14 @@ void receive(const MyMessage &message) {
}
```

### {% linkable_title Heartbeats %}

Sending a heartbeat from the MySensors sketch to home assistant activates the smartSleep functionality in home assistant. This means that messages are buffered and only sent to the device upon receiving a heartbeat from the device. State changes are stored so that only the last requested state change is sent to the device. Other types of messages are queued in a FIFO queue. SmartSleep is useful if you want to sleep a device, eg to be able to have it battery powered. See the MySensors library API for information on how to send heartbeats and sleep device.
Copy link
Member

@MartinHjelmare MartinHjelmare Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think you should write: "Sending a heartbeat from the MySensors device to Home Assistant activates...".
  • I think we write home assistant with capital H and A in the docs: Home Assistant. Please check that we're consistent with the rest of the docs.
  • SmartSleep is specifically useful for actuator devices, that expects incoming messages. Sensors that only send messages do not really need to be "smartSleeping" but can use normal "sleep". Please clarify this.

Heartbeat section updated based on comments.
Visit the [library api] of MySensors for more information.

[library api]: https://www.mysensors.org/download/sensor_api_15
[MySensors 1.x library api]: https://www.mysensors.org/download/sensor_api_15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this link cause the old page has been removed so link leads to a 404 page.

Single link to access all versions of MySensors code and API reference.
@MartinHjelmare MartinHjelmare merged commit f45e982 into home-assistant:current Jan 7, 2017
@MartinHjelmare
Copy link
Member

Thanks again!

fabaff pushed a commit that referenced this pull request Jan 14, 2017
* Heartbeats section added

Added basic documentation of smartSleep functionality within HA based on receiving a heartbeat signal form MySensor node.

* Heartbeat info clarified.

Heartbeat section updated based on comments.

* MyS library api link updated

Single link to access all versions of MySensors code and API reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants