Document the steam_source option for Amcrest cameras #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colinodell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @tchellomello to be potential reviewers. |
2 tasks
|
Looks good to me. I think we can add a table on the documentation with a supportability matrix. I'm going to add this on the https://github.com/tchellomello/python-amcrest page as well. |
|
@colinodell good job!!! awesome!! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the new
stream_sourceconfiguration option implemented in home-assistant/core#5217.It also includes a tip to help anyone who runs into this firmware issue
Pull request in home-assistant (if applicable): home-assistant/core#5217