-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Image processing #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image processing #1742
Conversation
@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @mnoorenberghe to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I have some quick suggestions to make this clearer to read.
Image processing enables Home Assistant to process image from cameras. | ||
As source is only supported camera entities. | ||
|
||
For interval controll, use `scan_interval` in platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "control"
ha_release: 0.36 | ||
--- | ||
|
||
Image processing enables Home Assistant to process image from cameras. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide example YAML to setup this platform.
--- | ||
|
||
Image processing enables Home Assistant to process image from cameras. | ||
As source is only supported camera entities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're trying to say:
"Only camera entities are supported as sources."
... | ||
``` | ||
|
||
follow event data while be present: `entity_id`, `plate`, `confidence` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The following event attributes will be present:"
ha_release: 0.36 | ||
--- | ||
|
||
[OpenAlpr](http://www.openalpr.com/) integration for Home Assistant allows you to process licences plates from a camera. You can use them to open a garage door or trigger any other [automation](https://home-assistant.io/components/automation/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"licences plates" should be "licence plates"
``` | ||
Configuration variables: | ||
|
||
- **region** (*Required*): Country or region. List of Supported [value](https://github.com/openalpr/openalpr/tree/master/runtime_data/config). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/value/values/
Configuration variables: | ||
|
||
- **region** (*Required*): Country or region. List of Supported [value](https://github.com/openalpr/openalpr/tree/master/runtime_data/config). | ||
- **api_key** (*Required*): You need a api key from [OpenAlpr Cloud](https://cloud.openalpr.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: there is an extra space before OpenAlpr
|
||
- **region** (*Required*): Country or region. List of Supported [value](https://github.com/openalpr/openalpr/tree/master/runtime_data/config). | ||
- **api_key** (*Required*): You need a api key from [OpenAlpr Cloud](https://cloud.openalpr.com/). | ||
- **confidence** (*Optional*): Default 80. The minimum of confidence in percent to process with Home-Assistant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the hyphen in "Home-Assistant"
- **api_key** (*Required*): You need a api key from [OpenAlpr Cloud](https://cloud.openalpr.com/). | ||
- **confidence** (*Optional*): Default 80. The minimum of confidence in percent to process with Home-Assistant. | ||
- **source** (*Required*): | ||
- **entities** (*Required*): A list of device to add in Home-Assistant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/device/devices/
- **api_key** (*Required*): You need a api key from [OpenAlpr Cloud](https://cloud.openalpr.com/). | ||
- **confidence** (*Optional*): Default 80. The minimum of confidence in percent to process with Home-Assistant. | ||
- **source** (*Required*): | ||
- **entities** (*Required*): A list of device to add in Home-Assistant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the hyphen in "Home-Assistant"
Description:
Add component image_processing with platform.
Pull request in home-assistant (if applicable): home-assistant/core#5166