Skip to content

Update media_player.vlc.markdown #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2017
Merged

Update media_player.vlc.markdown #1771

merged 2 commits into from
Jan 15, 2017

Conversation

MrMep
Copy link
Contributor

@MrMep MrMep commented Jan 14, 2017

Integration consequent to update #5334

Description:

Pull request in home-assistant (if applicable): home-assistant/core#5334

Integration consequent to update home-assistant#5334
@mention-bot
Copy link

@MrMep, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @tbarbette to be potential reviewers.

@MrMep MrMep mentioned this pull request Jan 14, 2017
8 tasks
```

Configuration variables:

- **name** (*Optional*): The name to use in the frontend.
- **arguments** (*Optional*): additional arguments to be passed to VLC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional should be capitalized. Otherwise looks good!

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, we try to keep the configuration sample minimal Thus no optional entries.

Thanks 🐦

@fabaff fabaff merged commit 27d03a3 into home-assistant:next Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants