Skip to content

Fix Xiaomi-miio humidifiers - correct modes and document attributes #18867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2021
Merged

Fix Xiaomi-miio humidifiers - correct modes and document attributes #18867

merged 2 commits into from
Aug 9, 2021

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Aug 9, 2021 •
edited
Loading

Proposed change

Small correction for Xiaomi-miio humidifiers

  • Operation modes for humidifiers have a capital.
  • Document attributes for humidfiers

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@jbouwh jbouwh requested review from rytilahti and syssi as code owners August 9, 2021 15:54
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Aug 9, 2021
bieniu
bieniu reviewed Aug 9, 2021
View reviewed changes
@bieniu
Copy link
Member

bieniu commented Aug 9, 2021

You can add motor_speed sensor for CA1 and CB1.

@jbouwh @bieniu
Update source/_integrations/xiaomi_miio.markdown
259be09 
Co-authored-by: Maciej Bieniek <bieniu@users.noreply.github.com>
frenck
frenck approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 👍

@frenck frenck merged commit c07fd11 into home-assistant:current Aug 9, 2021
@jbouwh jbouwh deleted the xiaomi-miio-humidifier-attributes branch August 9, 2021 17:36
raman325 pushed a commit to raman325/home-assistant.io that referenced this pull request Aug 10, 2021
@jbouwh @bieniu @raman325
Fix Xiaomi-miio humidifiers - correct modes and document attributes (h…
2933a13 
…ome-assistant#18867)

Co-authored-by: Maciej Bieniek <bieniu@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bieniu bieniu bieniu left review comments

@frenck frenck frenck approved these changes

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

@syssi syssi Awaiting requested review from syssi syssi is a code owner

Assignees
No one assigned
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbouwh @bieniu @frenck @homeassistant