Capital letter in config not allowed? #1933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey guys. Was following your example by just copy paste it and had errors with capital letters. Ist that right that no capital letter are allowed ? Then we would have to change all the configs. I just made on to show you an example. Greety ThUnD3r|Gr33n
|
@thundergreen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Danielhiversen, @Oliv3rDog and @robbiet480 to be potential reviewers. |
|
Yes, capital letter not allowed. |
|
Just change it on github and make a pull request
Am 01.02.2017 22:00 schrieb "Oliv3rDog" <notifications@github.com>:
… Yes, capital letter not allowed.
We need to change HDMI to hdmi and AV to av
Not sure how to help doing that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMtAfxPyWYtYaPTJUTgKZW7irFhZ4tJPks5rYPJwgaJpZM4Lz45c>
.
|
|
done... but I think @thundergreen have already made it... |
|
Only one example
Am 01.02.2017 22:39 schrieb "Oliv3rDog" <notifications@github.com>:
… done... but I think @thundergreen <https://github.com/thundergreen> have
already made it...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMtAf_R4w0HwIUf-HdOk2Ln02p6worgEks5rYPuNgaJpZM4Lz45c>
.
|
|
I will take #1935 as both PR are fixing the same things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys. Was following your example by just copy paste it and had errors with capital letters. Ist that right that no capital letter are allowed ? Then we would have to change all the configs. I just made on to show you an example.
Greety
ThUnD3r|Gr33n
Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#