Skip to content

Reflect Tuya IoT Platform changes to names and webpage structure #19599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2021
Merged

Reflect Tuya IoT Platform changes to names and webpage structure #19599

merged 4 commits into from
Oct 5, 2021

Conversation

drthanwho
Copy link
Contributor

Proposed change

Second attempt of my abomination of a previous PR #19569

Tuya IoT Platform has changed some names and structure of their pages that contradict with current instructions. Complete restructure of documentation for better flow, instead of a copy paste from Tuya's dev wiki.

  1. Updated names based on current edition of their platform.
  2. Addition of ΝΟΤΕ about being prompted to subscribe to a plan to clarify this is free.
  3. Remove notes
  4. New screenshots to reflect the changes

📌 Needs to be added to 2021.10 milestone

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 4, 2021
@probot-home-assistant probot-home-assistant bot added next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 4, 2021
@ludeeus ludeeus removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 4, 2021
@home-assistant home-assistant deleted a comment from probot-home-assistant bot Oct 4, 2021
ludeeus
ludeeus requested changes Oct 4, 2021
View reviewed changes
drthanwho
drthanwho commented Oct 4, 2021
View reviewed changes
drthanwho
drthanwho commented Oct 4, 2021
View reviewed changes
ludeeus
ludeeus reviewed Oct 5, 2021
View reviewed changes
ludeeus
ludeeus reviewed Oct 5, 2021
View reviewed changes
ludeeus
ludeeus previously approved these changes Oct 5, 2021
View reviewed changes
@ludeeus ludeeus requested a review from frenck October 5, 2021 07:04
frenck and others added 2 commits October 5, 2021 11:44
@frenck @ludeeus
Update source/_integrations/tuya.markdown
a6c8801 
Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
@frenck @ludeeus
Update source/_integrations/tuya.markdown
6aee7c2 
Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
@frenck frenck added this to the 2021.10.0 milestone Oct 5, 2021
frenck
frenck approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @drthanwho 👍

Happy Hacktoberfest 🎉

../Frenck

@frenck frenck merged commit 37e9542 into home-assistant:next Oct 5, 2021
@drthanwho drthanwho mentioned this pull request Oct 5, 2021
Closed
8 tasks
@zlinoliver
Copy link
Contributor

Hi @frenck @drthanwho @ludeeus , thanks for the help on updating the markdown file. One last content need to update is the supported platforms, we don't have cover platform support in this release, we should remove the related content in "Supported Platforms" and "Categories". Could you help to update it?

@balloob
Copy link
Member

balloob commented Oct 6, 2021

@zlinoliver it's gone, it just hasn't been merged yet to the rc website. That will be done before the release. You can see the upcoming version here https://next.home-assistant.io/integrations/tuya

@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Oct 6, 2021
frenck added a commit that referenced this pull request Oct 6, 2021
@drthanwho @ludeeus @frenck
Reflect Tuya IoT Platform changes to names and webpage structure (#19599
5c74085 
)

Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@ludeeus ludeeus ludeeus left review comments

Assignees
No one assigned
Labels
cherry-picked This PR has been manually picked and merged into the current branch cla-signed Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! next This PR goes into the next branch
Projects
None yet
Milestone
2021.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@drthanwho @zlinoliver @balloob @frenck @ludeeus @homeassistant