Skip to content

updating weather template example #19799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

cturra
Copy link
Contributor

@cturra cturra commented Oct 15, 2021

Proposed change

marjor changes are:

  • added condition_template that pulls state from a weather sensor rather than statically assigning it as sunny
  • updated forecast_template to use state_attr() as recommended in templating documentation.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: N/A
  • Link to parent pull request in the Brands repository: N/A
  • This PR fixes or closes issue: N/A

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

marjor changes are:
* added `condition_template` that pulls state from a weather sensor
* updated `forecast_template` to use state_attr() as recommended
in [templating documentation](https://www.home-assistant.io/docs/configuration/templating/).
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Oct 15, 2021
@probot-home-assistant probot-home-assistant bot added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 15, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cturra 👍

@frenck frenck merged commit cd78da0 into home-assistant:current Oct 16, 2021
@cturra cturra deleted the weather-tmpl-example-updates branch October 16, 2021 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants