Fix merge error & added doc for sensehat new flag #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodinosaur, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff to be a potential reviewer. |
fabaff
reviewed
Feb 23, 2017
| @@ -26,6 +26,7 @@ sensor: | |||
| - temperature | |||
| - humidity | |||
| - pressure | |||
| is_hat_attached: True|False | |||
There was a problem hiding this comment.
It's an optional entry. Thus don't add it. We try to keep the configuration samples minimal.
fabaff
requested changes
Feb 23, 2017
| @@ -34,56 +35,13 @@ Configuration variables: | |||
| - 'temperature' | |||
| - 'humidity' | |||
| - 'pressure' | |||
| is_hat_attached (Optional): True|False boolean; True declares the SenseHAT _is_ physically on the Raspberry Pi | |||
There was a problem hiding this comment.
Please state what the default is.
|
|
||
| ### {% linkable_title Installation instruction for the All-In-One installer and HASSbian %} | ||
| #### Customizing the Sense HAT data |
There was a problem hiding this comment.
This part was already added by #2009. I suggest that you limit your PR to the new Boolean and make it against next which is the right branch for new features.
There was a problem hiding this comment.
The previous issue has a styling issue when merge occurred. This corrects that on top of that PR. This is the correct version.
fabaff
pushed a commit
that referenced
this pull request
Feb 23, 2017
* Fix merge error & added doc for sensehat new flag * Changes as per PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a new Flag for if the Sensehat is Attached to the R-Pi
Fixed a messed up merge
Pull request in home-assistant (if applicable): home-assistant/core#5883