Skip to content

Create sensor.pushbullet.markdown #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Create sensor.pushbullet.markdown #2115

wants to merge 1 commit into from

Conversation

jotunacorn
Copy link
Contributor

Description:
Added doc for the new pushbullet sensor

Pull request in home-assistant (if applicable): home-assistant/core#6188

@jotunacorn jotunacorn mentioned this pull request Feb 23, 2017
Closed
6 tasks
Landrash
Landrash requested changes Mar 8, 2017
View reviewed changes
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can almost be merged.

Suggest you separate the current example config and have this one and a minimal config example without the optional variables.

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Mar 8, 2017
@rpitera
Copy link
Contributor

rpitera commented Mar 15, 2017

I feel like this could also use a sentence or two about what a mirrored notification is or at least a link to an explanation. Also may be a good idea to explain that mirrored notification only works from Android devices at this time.

@fabaff
Copy link
Member

fabaff commented Mar 31, 2017

The Pull request in the main repository was closed. Please re-open this PR is your changes are ready to merge.

@fabaff fabaff closed this Mar 31, 2017
@rpitera
Copy link
Contributor

rpitera commented Mar 31, 2017

@fabaff - Not sure how to reopen the PR, but this is the addition I would propose:

Notification Mirroring allows users to see their Android device's notifications on their computer. It must be first enabled in the app and is currently only available on the Android platform. For more information, please see [this announcement](https://blog.pushbullet.com/2013/11/12/real-time-notification-mirroring-from-android-to-your-computer/) on the Pushbullet Blog

@jotunacorn
Copy link
Contributor Author

@rpitera
I will reopen it and add your suggestion as soon as i get around to fixing the pullrequest in the main branch. The fixes are mostly renaming and moving around stuff but I'm not sure when I'll be able to do it.

@rpitera
Copy link
Contributor

rpitera commented Apr 7, 2017

Thanks!

@jotunacorn jotunacorn mentioned this pull request Apr 19, 2017
Merged
6 tasks
jotunacorn added a commit to jotunacorn/home-assistant.github.io that referenced this pull request Apr 20, 2017
@jotunacorn
Create sensor.pushbullet.markdown
e0062b0 
Reopening of home-assistant#2115
**Description:**
Added doc for the new pushbullet sensor


**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/core#7182
@jotunacorn jotunacorn mentioned this pull request Apr 20, 2017
Merged
fabaff pushed a commit that referenced this pull request Apr 22, 2017
@jotunacorn @fabaff
Create sensor.pushbullet.markdown (#2461)
005ab6f 
* Create sensor.pushbullet.markdown

Reopening of #2115
**Description:**
Added doc for the new pushbullet sensor


**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/core#7182

* Updated date

* Add ha_release and some minor format changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Landrash Landrash Landrash requested changes

Assignees
No one assigned
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jotunacorn @rpitera @fabaff @Landrash