Document notify.webostv icon configuration #2188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andersonshatch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @TheRealLink, @balloob and @fabaff to be potential reviewers. |
5 tasks
Landrash
previously requested changes
Mar 7, 2017
| @@ -33,6 +33,7 @@ Configuration variables: | |||
| - **host** (*Required*): The IP of the LG WebOS Smart TV, e.g. 192.168.0.10 | |||
| - **name** (*Required*): The name you would like to give to the LG WebOS Smart TV. | |||
| - **filename** (*Optional*): The filename where the pairing key with the TV should be stored. This path is relative to Home Assistant's config directory. It defaults to `webostv.conf`. | |||
| - **icon** (*Optional*): The path to an image file to use as the icon in notifications -- if provided, this image will override the Home Assistant logo. | |||
There was a problem hiding this comment.
Suggest you remove the double dashes and make it two separate sentences.
|
|
||
| The icon can be overridden for individual notifications by providing a path to an alternative icon image to use: | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
Since it's fairly common for folks to copy the examples I think you should make it a full automation example as the one above.
|
Thanks for the review @Landrash -- I've addressed both of your suggestions now. |
|
This is pointed at current and not at next. Should be merged after we release 0.40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add configuration for notify.webostv icons
Pull request in home-assistant: home-assistant/core#6380