Skip to content

Update documentation to use the generic python3 version of venv #21885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2022
Merged

Update documentation to use the generic python3 version of venv #21885

merged 1 commit into from
Mar 27, 2022

Conversation

YogoGit
Copy link
Contributor

@YogoGit YogoGit commented Mar 3, 2022

Proposed change

We use generic python3 for installing packages in later steps, so there's no need to specify a specific version of venv in the documentation, as most any modern version of python3 should work properly.

Type of change

Documentation change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
  • X ] The documentation follows the Home Assistant documentation standards.

@YogoGit
Use the generic python3 version of venv
3e67e91 
We use generic python3 for installing packages in later steps, so there's no need to specify a specific version of venv, as most any modern version of python3 should work properly.
@homeassistant
Copy link

Hi @YogoGit,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 3, 2022
frenck
frenck approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @YogoGit 👍

@frenck frenck merged commit 0e9cf0a into home-assistant:current Mar 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YogoGit @homeassistant @frenck