Skip to content

Updated VOC documentation #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2017
Merged

Updated VOC documentation #2215

merged 1 commit into from
Mar 17, 2017

Conversation

molobrakos
Copy link
Contributor

Description:
The Volvo on call device tracker was transformed into its own component.

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

@mention-bot
Copy link

@molobrakos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @lamiskin to be potential reviewers.

Landrash
Landrash requested changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor feedback.

source/_components/volvooncall.markdown

To use Volvo On Call in your installation, add the following to your `configuration.yaml` file:

```yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I suggest you have a minimal example and this one as a advanced example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll fix. Am I supposed to add sensor.volvooncall, switch.volvooncall etc as well? (currently they can only instantiated indirectly by the component, not by the user)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 7, 2017
@molobrakos molobrakos mentioned this pull request Mar 14, 2017
Closed
@Landrash Landrash merged commit 3044db2 into home-assistant:next Mar 17, 2017
@tomoqv
Copy link

tomoqv commented May 16, 2017

Hello!
could somebody explain to me what I am missing in my VOC config? I am not getting any device_tracker info for my Volvo. Pls see this thread: https://community.home-assistant.io/t/trying-to-add-volvo-on-call-position/17459/6

Thank you!
Tomas

@molobrakos molobrakos deleted the voc branch May 16, 2017 11:04
@Landrash
Copy link
Contributor

@tomoqv Please keep support to the forums or gitter chat.

@home-assistant home-assistant locked and limited conversation to collaborators May 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Landrash Landrash Landrash approved these changes

Assignees
No one assigned
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@molobrakos @mention-bot @tomoqv @Landrash