Skip to content

Update jewish calendar docs #22175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Update jewish calendar docs #22175

merged 1 commit into from
Mar 28, 2022

Conversation

tsvi
Copy link
Contributor

@tsvi tsvi commented Mar 28, 2022

Fixes #22169
Thanks @aniceberg for pointing out the mistake in the docs. This is due to the fact that the library returns true/false but homeassistant surfaces it as on/off.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Fixes home-assistant#22169 
Thanks @aniceberg for pointing out the mistake in the docs. This is due to the fact that the library returns true/false but homeassistant surfaces it as on/off.
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 28, 2022
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Thanks

@fabaff fabaff merged commit f09431a into home-assistant:current Mar 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
@tsvi tsvi deleted the patch-6 branch May 23, 2022 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issur Melacha Boolean Value
3 participants