Skip to content

Documentation for 'recorder' sometimes incorrectly mentions 'history'. #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

herm
Copy link
Contributor

@herm herm commented Mar 11, 2017

See title.

@mention-bot
Copy link

@herm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nodomain, @michaelarnauts and @fabaff to be potential reviewers.

@herm herm changed the base branch from next to current March 11, 2017 02:30
@herm herm changed the base branch from current to next March 11, 2017 02:30
@herm herm force-pushed the recorder_history branch from 23952d9 to 7a1fe5a Compare March 11, 2017 02:34
@herm herm changed the base branch from next to current March 11, 2017 02:35
@herm
Copy link
Contributor Author

herm commented Mar 11, 2017

Sorry, I selected the wrong base branch first and had to fix this.

@Landrash
Copy link
Contributor

First good job and nice to have it fixed, then a small nit pick.
Avoid descriptions such as see title, in general it's good practice to fill out fields as requested if not only for consistency but also it makes it easier for folks using screen readers and similar devices.

Thank you 🍪

@Landrash Landrash merged commit 7e2852f into home-assistant:current Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants