Skip to content

Clarify service name in Discord #22363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented Apr 12, 2022

Proposed change

It appears that some users may have been confused with the name they are expecting for the notify service in Discord.
The example service calls may be the cause. This PR attempts to make it clear to the user that the name will match the one they give to their app in the Discord dev portal.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Apr 12, 2022
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 12, 2022
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

@frenck frenck merged commit 1e9f902 into home-assistant:current Apr 12, 2022
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Apr 12, 2022
@tkdrob tkdrob deleted the discord_patch branch April 12, 2022 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants